DAP: need to wait for connection #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the breakpoint by `debugger()` method, the connection is needed and wait for the connection if it is not connected. With the fowllowing scenario, the debugger raises an exception becuase the connection is kept (but disconnection violate this assumption) 1. run the script includes `debugger` call 2. connect to DAP client 3. disconnect from DAP client 4. call `debugger` method To solve this issue, it needs to wait for the connection. `UI_ServerBase::sock` and `UI_ServerBase::readline` do it and we can use them on DAP connection, so remove `UI_DAP::sock` and `UI_DAP::readline`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the breakpoint by
debugger()method, the connection isneeded and wait for the connection if it is not connected.
With the fowllowing scenario, the debugger raises an exception
becuase the connection is kept (but disconnection violate this
assumption)
debuggercalldebuggermethodTo solve this issue, it needs to wait for the connection.
UI_ServerBase::sockandUI_ServerBase::readlinedo it and wecan use them on DAP connection, so remove
UI_DAP::sockandUI_DAP::readline.