Enable "step back <n>" while replay #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ono-max
force-pushed
the
patch-6
branch
4 times, most recently
from
cf84579 to
915aabd
Compare
ono-max
commented
Oct 18, 2022
| def step_back iter | ||
| @index += iter | ||
| if @index > @log.size | ||
| @index = @log.size |
There was a problem hiding this comment.
When n of "step back " is larger than current @index, @index will be size of log.
ko1
reviewed
Oct 25, 2022
lib/debug/session.rb
Outdated
| @@ -1056,12 +1056,14 @@ def step_command type, arg | |||
| else | |||
| leave_subsession [:step, type, arg&.to_i] | |||
| end | |||
| when /\Aback\z/, /\Areset\z/ | |||
| when /\A(back)\z/, /\A(reset)\z/, /\A(back)\s(\d+)\z/ | |||
ko1
reviewed
Oct 25, 2022
lib/debug/session.rb
Outdated
| @@ -1056,12 +1056,14 @@ def step_command type, arg | |||
| else | |||
| leave_subsession [:step, type, arg&.to_i] | |||
| end | |||
| when /\Aback\z/, /\Areset\z/ | |||
| when /\A(back)\z/, /\A(reset)\z/, /\A(back)\s(\d+)\z/ | |||
There was a problem hiding this comment.
Suggested change
| when /\A(back)\z/, /\A(reset)\z/, /\A(back)\s(\d+)\z/ | |
| when /\A(back)\z/, /\A(back)\s+(\d+)\z/, /\A(reset)\z/ |
ko1
reviewed
Oct 25, 2022
lib/debug/session.rb
Outdated
| if type != :in | ||
| @ui.puts "only `step #{arg}` is supported." | ||
| :retry | ||
| else | ||
| request_tc [:step, arg.to_sym] | ||
| type = $1.to_sym | ||
| iter = $2.to_i unless $2.nil? |
There was a problem hiding this comment.
Suggested change
| iter = $2.to_i unless $2.nil? | |
| iter = $2&.to_i |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
step back <n>doesn't work in replay mode. This PR fixes it.