Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Process.daemon #856

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Support Process.daemon #856

merged 2 commits into from
Dec 2, 2022

Conversation

shunichi
Copy link
Contributor

@shunichi shunichi commented Dec 2, 2022 •
edited
Loading

Description

Threads could not be started after Process.daemon since the session server thread was gone.

The session must be activated like fork child processes.

@ko1
Copy link
Collaborator

ko1 commented Dec 2, 2022 •
edited
Loading

Thank you.
One thing we need to consider is what's happens when it is using local debugging...
warning before calling deaemon?

@shunichi
Copy link
Contributor Author

shunichi commented Dec 2, 2022

@ko1 I'll add the following message before Process.daemon.
Is it OK?

DEBUGGER__.warn "Can't debug the code after Process.daemon locally. Use the remote debugging feature."

@ko1
Copy link
Collaborator

ko1 commented Dec 2, 2022

Ok! Can you add the condition?

@shunichi
Copy link
Contributor Author

shunichi commented Dec 2, 2022

@ko1 I added the condition.

@ko1 ko1 merged commit f24a6f9 into ruby:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shunichi @ko1