Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”Ό Update CI matrix Ruby versions #880

Merged
merged 3 commits into from
Mar 7, 2023

Conversation

yamashush
Copy link
Contributor

@yamashush yamashush commented Jan 2, 2023

Description

Update CI matrix ruby versions.

  • Add 3.2 ✨
  • Remove 2.6 πŸ”₯

ref: https://www.ruby-lang.org/en/downloads/branches/

Ruby 3.2
status: normal maintenance
release date: 2022-12-25
Ruby 2.6
status: eol
release date: 2018-12-25
EOL date: 2022-04-12

@st0012
Copy link
Member

st0012 commented Jan 2, 2023

I think 2.6 shouldn't be removed because it's still supported by this gem. EOL of a version only means the version itself won't receive further updates (usually), but it doesn't mean gems have dropped support for it.

@gwillcox-r7
Copy link

gwillcox-r7 commented Jan 5, 2023

@st0012 My understanding is that Ruby 2.6 is no longer receiving any updates anymore and Ruby 2.7 is soon to enter EOL state and enter a similar condition. I'm going off of the info on https://www.ruby-lang.org/en/downloads/ though, which states that Ruby 2.6.10 is not maintained anymore and 2.7.x is soon to enter the same state.

On a side note I think the 3.2 support here may be causing some of the tests to fail as it seems we are returning objects that aren't the types we are expecting; this may require some further investigation and code updates.

@st0012
Copy link
Member

st0012 commented Jan 6, 2023

@gwillcox-r7 As I've said, a version of Ruby stop receiving updates != gems will drop support of it right away. Given that Ruby 2.6 is still supported by this particular gem, it's better to make sure it's tested on CI as well.

@yamashush
Copy link
Contributor Author

Sorry for late reply, and I've understood that it is necessary to leave Ruby 2.6.
Thank you :) :) :)

Is it ok to add Ruby 3.2?

@st0012
Copy link
Member

st0012 commented Jan 7, 2023

Of course, other libs like IRB or reline also has 3.2 in their test matrixes now πŸ™‚

@st0012
Copy link
Member

st0012 commented Feb 17, 2023

cc @ko1 I think this could help distinguish if failures are caused by Ruby 3.2 and/or 3.3.

@ko1 ko1 merged commit f7e5791 into ruby:master Mar 7, 2023
@ko1
Copy link
Collaborator

ko1 commented Mar 7, 2023

Thank you for the patch and discussion.

  • I don't have any opinion about Ruby 2.6, and I agree dropping Ruby 2.6 makes things easy.
  • But just now we have no trouble on Ruby 2.6. So I keep Ruby 2.6 matrix.

If you find any trouble on Ruby 2.6 on CI, please tell me and drop it.

@ko1
Copy link
Collaborator

ko1 commented Mar 7, 2023

(in other words) we shouldn't hesitate to introduce 2.6 incompatible code on debug.gem just now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants