Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Session#extend_feature into Session class #964

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Move Session#extend_feature into Session class #964

merged 1 commit into from
Apr 21, 2023

Conversation

ono-max
Copy link
Member

@ono-max ono-max commented Apr 16, 2023 •
edited
Loading

Currently, extend_feature method is defined outside of Session class. This PR fixes it.

@ono-max
Move Session#exnted_feature into Session class
e43dd88 
Currently, `exnted_feature` method is defined outside of Session class. This PR fixes it.
@ko1 ko1 merged commit ce7e342 into ruby:master Apr 21, 2023
@choosen
Copy link

choosen commented May 12, 2023

@ono-max @ko1 There is a typo here and in changelog: #extend_feature
good that it is correct in code :D

@ono-max ono-max deleted the patch-245 branch May 12, 2023 08:10
@ono-max ono-max changed the title Move Session#exnted_feature into Session class Move Session#extend_feature into Session class May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ono-max @choosen @ko1