Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit test_finish_0 because it failed with only reline environment #970

Merged
merged 1 commit into from
May 4, 2023

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented May 2, 2023

Description

I have a plan to remove ext/readline that is GNU Readline wrapper from Ruby 3.3.

But test_finish_0 is failing with Ubuntu environment. see ruby/ruby#7781 (comment).

I'm not sure why fin 0 is failed with its environment. It may be issue of Reline.

Reproduction instruction

  1. Use Ubuntu environment.
  2. Checking out hsbt:extract-ext-readline branch.
  3. ./configure, make ruby && make up && make && make test-bundled-gems

/cc @ruby/irb-reline

@ko1
Copy link
Collaborator

ko1 commented May 4, 2023

I couldn't reproduce this issue by self removing readline.so from 3.1.2 and recent master (March).

$ ruby test/console/control_flow_commands_test.rb -n /finish_0/

I'll merge it and revisit it.

@ko1 ko1 merged commit 1c1849f into master May 4, 2023
@ko1 ko1 deleted the omit-only-reline-env branch May 4, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants