Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental features #135

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Remove experimental features #135

merged 1 commit into from
Nov 18, 2019

Conversation

yuki24
Copy link
Member

@yuki24 yuki24 commented Nov 18, 2019

As part of the effort to make this gem a default gem, I wanted to remove uncommon features that are hard to maintain. We noticed that the tests for experimental features caused test pollution in Ruby's test suite, so I'm removing the entire thing.

I don't think the experimental features are used that much and it shouldn't be very disruptive in production since it's just about DX. We can also always revert if we want to.

@yuki24 yuki24 self-assigned this Nov 18, 2019
@yuki24 yuki24 force-pushed the remove-experimental-features branch from b7f0473 to 6397b21 Compare November 18, 2019 02:28
@yuki24 yuki24 force-pushed the remove-experimental-features branch from 6397b21 to 2c632e2 Compare November 18, 2019 02:41
@yuki24 yuki24 merged commit 9493839 into master Nov 18, 2019
@yuki24 yuki24 deleted the remove-experimental-features branch November 18, 2019 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant