Skip to content

Conversation

@satmandu
Copy link
Contributor

Fixes #103

  • PR to solve the aforementioned issue of FileUtils.install not creating a destination directory before installing a file to a destination directory.
  • Using mkdir_p on the destination directory solves that issue.

@satmandu satmandu requested review from supechicken and uberhacker and removed request for supechicken and uberhacker January 11, 2023 17:04
@satmandu
Copy link
Contributor Author

Is this acceptable @hsbt ?

@hsbt
Copy link
Member

hsbt commented Jan 17, 2023

Thanks for your work. At least, We need to the additional tests. Can you add them?

@satmandu
Copy link
Contributor Author

Thanks for your work. At least, We need to the additional tests. Can you add them?

What are the additional needed tests?

@satmandu
Copy link
Contributor Author

@hsbt What additional tests are needed?

@hsbt
Copy link
Member

hsbt commented Jan 19, 2023

for your changes.

@satmandu
Copy link
Contributor Author

Ah! I will modify https://github.com/ruby/fileutils/blob/master/test/fileutils/test_fileutils.rb ...

@satmandu
Copy link
Contributor Author

Does this work?

@hsbt
Copy link
Member

hsbt commented Jan 20, 2023

I'll fix this CI fails. It's not related with your tests.

@satmandu
Copy link
Contributor Author

@hsbt Any chance of this getting merged?

@hsbt hsbt merged commit 8af16ba into ruby:master Feb 10, 2023
matzbot pushed a commit to ruby/ruby that referenced this pull request Feb 10, 2023
(ruby/fileutils#104)

* Add mkdir_p to FileUtils.install

* Adjust raise message.

* adjust raise language

* handle trailing slash in dest

* simplify

* Add tests
@satmandu satmandu deleted the install_mkdir_p branch February 10, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FileUtils.install needs integrated mkdir_p

4 participants