Skip to content

Narrow down supported versions #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 30, 2025
Merged

Narrow down supported versions #863

merged 7 commits into from
May 30, 2025

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented May 21, 2025 •
edited
Loading

Dear Maintainers of Rails Repositories(@tk0miya, @ydah, @hibariya, @Little-Rubyist).
Please review this PR.

I have responded about activerecord to implement #788.

Point of review

Please see gems/activerecord/README.md.
If this text allows, it will be expanded to other rails gems.
Other gems do not require review.

What will change?

Supported Versions

  • 8.0 and 7.2 are the targets.
  • Simply copied the original file instead of symlink.
  • Some of the test files were copied from 6.0.

Unsupported Versions

  • 7.1, 7.0, 6.1 and 6.0 are the targets.
  • Deleted test.
  • Excluded from rubocop.
  • Symlink was left in place.

@github-actions GitHub Actions
Copy link

@ksss Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

activerecord

You changed RBS files for an existing gem.
You can merge this PR yourself because you are a reviewer of this gem.
Just comment /merge to merge this PR.

You can also request a review from other reviewers if you want.

tk0miya
tk0miya reviewed May 29, 2025
View reviewed changes
Copy link
Contributor

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! +1 (APPROVE)

But, unfortunately, I can't mark this approved because it seems I don't have permission to approve this PR...
Maybe this PR contains .rubocop.yml and README.md that are placed outside of my review area.

@github-actions GitHub Actions
Copy link

Thanks for your review, @tk0miya!

@ksss, @tk0miya This PR is ready to be merged.
Just comment /merge to merge this PR.

@tk0miya
Copy link
Contributor

tk0miya commented May 29, 2025

Ah, sorry for my confusion. Please forget my last comment. I've never had permission to approve in GitHub.
The only thing I can do is approve via "APPROVE" comment, not via the review interface.

@ksss
Copy link
Collaborator Author

ksss commented May 30, 2025 •
edited
Loading

@tk0miya Thanks!

@ksss
Copy link
Collaborator Author

ksss commented May 30, 2025

I will proceed with this PR merge and another gems, but please feel free to contact me if you have any problems.

@ksss
Copy link
Collaborator Author

ksss commented May 30, 2025

/merge

@github-actions github-actions bot merged commit e027cca into ruby:main May 30, 2025
6 checks passed
@ksss ksss deleted the separate-ln-activerecord branch May 30, 2025 01:20
yuzisee added a commit to yuzisee/gem_rbs_collection_edits that referenced this pull request Jun 4, 2025
@yuzisee
Get the tests working on 6.0 at first
f6a5e30 
but we'll backport to ruby#788 and ruby#863 as needed afterward
yuzisee added a commit to yuzisee/gem_rbs_collection_edits that referenced this pull request Jun 4, 2025
@yuzisee
Get the tests working on 6.0 at first
d494ab8 
but we'll backport to ruby#788 and ruby#863 as needed afterward
@yuzisee yuzisee mentioned this pull request Jun 4, 2025
Open
yuzisee added a commit to yuzisee/gem_rbs_collection_edits that referenced this pull request Jun 4, 2025
@yuzisee
Unify ActiveRecord behavior for errors, callbacks, and validations ac…
a475c60 
…ross all versions (6.0, 6.1, 7.0, 7.1, 7.2, 8.0)

We found these cleanups during ruby#859 but following ruby#788 → ruby#863 there is an initiative to simplify ActiveRecord maintenance.

This streamlines a few things across all versions to make it easier to maintain. Ideally after ruby#859 is merged, we can transfer those tests up to 8.0 as well.
@yuzisee yuzisee mentioned this pull request Jun 4, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jun 5, 2025
@yuzisee
Unify ActiveRecord behavior for errors, callbacks, and validations ac…
52a7ef8 
…ross all versions (6.0, 6.1, 7.0, 7.1, 7.2, 8.0) (#874)

We found these cleanups during #859 but following #788 → #863 there is an initiative to simplify ActiveRecord maintenance.

This streamlines a few things across all versions to make it easier to maintain. Ideally after #859 is merged, we can transfer those tests up to 8.0 as well.
This was referenced Jun 30, 2025
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tk0miya tk0miya tk0miya left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksss @tk0miya