Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPAddr#wildcard_mask #44

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Add IPAddr#wildcard_mask #44

merged 1 commit into from
Apr 10, 2024

Conversation

taketo1113
Copy link
Contributor

Added to get an address of wildcard mask which is like a reverse subnet mask.
It uses to configure a network device for ACL or OSPF.

Related links

@sorah
Copy link
Member

sorah commented Apr 5, 2024

Hi,

I'd like to take a look at this PR (sorry for being too late!)

I believe this is sourced from https://github.com/interop-tokyo-shownet/ipaddr-ext and I noticed the difference in license. Since ipaddr-ext has only 1 author (you), it'd be easy to merge if you relicense ipaddr-ext to match this gem (Dual license of Ruby/BSD-2-Clause) first.

I'm also interested in upstreaming of other extensions in ipaddr-ext to ruby/ipaddr if you'd like…!

@taketo1113
Copy link
Contributor Author

@sorah Thanks to reply.

I believe this is sourced from https://github.com/interop-tokyo-shownet/ipaddr-ext and I noticed the difference in license.

Yes. this is sourced from ipaddr-ext gem, and it's a same author (me).
I guess to no problems merging it, because ipaddr-ext gem is licensed under the MIT license.

I'm also interested in upstreaming of other extensions in ipaddr-ext to ruby/ipaddr if you'd like…!

Thanks! I will try to create PR for other extensions of ipaddr-ext gem.

@sorah sorah merged commit 036836d into ruby:master Apr 10, 2024
@taketo1113 taketo1113 deleted the wildcard_mask branch April 10, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants