Provide a base test class and let tests restore encodings conveniently #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `RelineInputMethod#initializes` calls `set_encoding`, which changes stdio/out/err and Encoding's default encoding values, we need to make sure any test that directly or indirectly (e.g. through Context) initializes `RelineInputMethod` restores encodings. `ReadlineInputMethod` also changes encodings but currently no tests cover it.
Since we now have a base TestCase, without_rdoc can just live there.
st0012
force-pushed
the
restructure-tests
branch
from
2951a5e to
c781820
Compare
Member
Author
|
FWIW, I also patched this locally to make sure nothing is missed: --- a/test/irb/helper.rb
+++ b/test/irb/helper.rb
@@ -2,6 +2,15 @@ require "test/unit"
module TestIRB
class TestCase < Test::Unit::TestCase
+ def teardown
+ assert_equal(Encoding.default_external, STDIN.external_encoding)
+ assert_equal(nil, STDIN.internal_encoding)
+ assert_equal(nil, STDOUT.external_encoding)
+ assert_equal(nil, STDOUT.internal_encoding)
+ assert_equal(nil, STDERR.external_encoding)
+ assert_equal(nil, STDERR.internal_encoding)
+ end
+ |
k0kubun
approved these changes
Nov 3, 2022
Member
k0kubun
left a comment
k0kubun
left a comment
There was a problem hiding this comment.
I hope this will reduce the number of future problems in encoding.
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Nov 3, 2022
conveniently (ruby/irb#429) * Create a base TestIRB::TestCase class * Save/restore encodings for tests that initializes InputMethod classes Because `RelineInputMethod#initializes` calls `set_encoding`, which changes stdio/out/err and Encoding's default encoding values, we need to make sure any test that directly or indirectly (e.g. through Context) initializes `RelineInputMethod` restores encodings. `ReadlineInputMethod` also changes encodings but currently no tests cover it. * Remove unnecessary TestHelper module Since we now have a base TestCase, without_rdoc can just live there. ruby/irb@c2874ec121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
RelineInputMethod#initializescallsset_encoding, which changes stdio/out/err and Encoding's default encoding values, we need to make sure any test that directly or indirectly (e.g. through Context) initializesRelineInputMethodrestores encodings.ReadlineInputMethodalso changes encodings but currently no tests cover it.