Simplify each_top_level_statement #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
force-pushed
the
each_toplevel_statement_refactor
branch
from
9ac0f6f to
7907a48
Compare
st0012
reviewed
May 17, 2023
| end | ||
| def save_prompt_to_context_io(ltype, indent, continue, line_num_offset) | ||
| # Implicitly saves prompt string to `@context.io.prompt`. This will be used in the next `@input.call`. | ||
| @prompt.call(ltype, indent, continue, @line_no + line_num_offset) |
There was a problem hiding this comment.
@prompt is not going to be nil in actual use cases because Irb#eval_input always calls RubyLex#set_prompt before calling RubyLex#each_top_level_statemen.
But I think this type of implicit dependency is risky and we should probably refactor that later.
st0012
approved these changes
May 19, 2023
Co-authored-by: Stan Lo <stan001212@gmail.com>
tompng
force-pushed
the
each_toplevel_statement_refactor
branch
from
da1c0aa to
dfd4ced
Compare
st0012
approved these changes
May 19, 2023
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
May 19, 2023
(ruby/irb#576) * Simplify each_top_level_statement, reduce instance vars * Update lib/irb/ruby-lex.rb Co-authored-by: Stan Lo <stan001212@gmail.com> * Remove unused ltype from TestRubyLex#check_state response * Remove unnecessary const path of TerminateLineInput * Combine duplicated code state check into method --------- ruby/irb@172453cec4 Co-authored-by: Stan Lo <stan001212@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is an extract of refactor from #500
Refactored each_top_level_statement
@exp_line_no@indent@continue@linefromruby-lex.rbdef each_top_level_statementtodef readmultilinecatch(:TERM_INPUT)andthrow :TERM_INPUTinto simple loop and breakdef lexbecause it is only used from test code now