Refactor eval history #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To confusion with `lib/irb/history.rb`
st0012
force-pushed
the
refactor-eval-history
branch
from
e1ad483
to
4249ca6
Compare
tompng
approved these changes
Jul 4, 2023
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jul 4, 2023
(ruby/irb#623) * Rename `ext/history.rb` to `ext/eval_history.rb` To confusion with `lib/irb/history.rb` * Add eval_history tests * Rename eval_history's History to EvalHistory to avoid confusion
mvz
added a commit
to cucumber/aruba
that referenced
this pull request
Dec 24, 2023
See ruby/irb#623. The file was removed and the corresponding feature should be activated by setting :EVAL_HISTORY.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature was not enabled by default, not tested, and could be easily confused with IRB's history saving feature. So in this PR I did these improvements:
limit - 1results, which is probably a bug. But since it's not widely used and we don't have any reports about it, I don't prioritise fixing it atm.