Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore IRB::InputCompletor for compatibility #730

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Restore IRB::InputCompletor for compatibility #730

merged 1 commit into from
Oct 14, 2023

Conversation

tompng
Copy link
Member

@tompng tompng commented Oct 14, 2023

CompletionProc and retrieve_completion_data seems to be used
ReservedWords Operators is used in one repository
Other constants and methods does not seem to be used

st0012
st0012 approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this fixes debug's test failure 👍

@st0012 st0012 merged commit 77265ef into ruby:master Oct 14, 2023
24 checks passed
matzbot pushed a commit to ruby/ruby that referenced this pull request Oct 14, 2023
@tompng @matzbot
[ruby/irb] Restore IRB::InputCompletor for compatibility
4e5c505 
(ruby/irb#730)

ruby/irb@77265efc5f
@st0012 st0012 mentioned this pull request Oct 14, 2023
Closed
@tompng tompng deleted the deprecated_input_completor branch October 29, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st0012 st0012 st0012 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tompng @st0012