Skip to content

Pin dev builds to 9.4 for now #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Pin dev builds to 9.4 for now #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion find-jruby-head-url-nokogiri.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
versions = Nokogiri::XML(xml).css('version').map(&:text)

versions.delete('9000.dev-SNAPSHOT')
most_recent = versions.max_by { |v| Gem::Version.new(v) }
most_recent = versions.grep(/9\.4/).max_by { |v| Gem::Version.new(v) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use an anchor here like /^9\.4/ to avoid potentially wrong matches?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't be here long enough to matter.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I couldn't review before your merged, and this is my review, and I'm the main maintainer of setup-ruby & related repos I would like you to address this. I want to be sure we don't get some strange behavior because it matches e.g. 9.3.9.4. And it's just more correct.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will never be a 9.3.9.4, nor a .9.4 for any previous release. In theory there could someday be a 10.0.9.4 or 10.9.4.0 but this patch will be gone before 10.0 is even released (within the next month).

Since I couldn't review before your merged

It was necessary to expedite because we started pushing 10 snapshot builds and I knew users would start seeing those in setup-ruby before we're ready. Given the time-sensitive nature I opted to merge in a working patch. I'll add your refinement now.


builds_url = "#{base_url}/#{most_recent}/maven-metadata.xml"
STDERR.puts builds_url
Expand Down