Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better test coverage #41

Closed
mernen opened this issue Aug 7, 2010 · 1 comment
Closed

Better test coverage #41

mernen opened this issue Aug 7, 2010 · 1 comment

Comments

@mernen
Copy link
Contributor

mernen commented Aug 7, 2010

The library needs more extensive testing. Through bug reports on json-jruby, I've noticed the following parts are not covered:

  • Bignums
  • Non-UTF strings
  • Strings with isolated surrogates (see issue json/ext handles isolated escaped surrogates inconsistently #38)
  • Generator::State getters and setters (settings are always being passed on initialization)
  • Strings whose internal buffer offset is nonzero (a rather specific implementation detail, but could be useful nonetheless), i.e.:
    str = 'xx["foobar"]'
    substr = str[2..-1]
    JSON.parse(substr) # confuses json-jruby 1.1.5
@hsbt
Copy link
Member

hsbt commented Jun 25, 2020

We welcome to your patch for test coverage.

@hsbt hsbt closed this as completed Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants