Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bigdecimal updates #362

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Fix for bigdecimal updates #362

merged 1 commit into from
Dec 20, 2018

Conversation

mrkn
Copy link
Member

@mrkn mrkn commented Dec 2, 2018

BigDecimal.new is no longer available from bigdecimal-1.4.0.
This pull request removes the dependencies that method.

@mrkn mrkn force-pushed the update_for_bigdecimal branch 2 times, most recently from 01255f1 to 891e46a Compare December 2, 2018 10:42
`BigDecimal.new` is no longer available from bigdecimal-1.4.0.
@mrkn mrkn force-pushed the update_for_bigdecimal branch from 891e46a to 7469100 Compare December 2, 2018 10:44
@mrkn
Copy link
Member Author

mrkn commented Dec 2, 2018

Note that the same change has been applied in ruby-trunk.

@kares
Copy link
Contributor

kares commented Dec 14, 2018

nice work, for the record I do have this one fixed for JRuby as well ... // cc @hsbt
its more changes on top of #361 ... so I'd like to ask if we could merge that one.

@hsbt hsbt merged commit fd6f86f into ruby:master Dec 20, 2018
@mrkn mrkn deleted the update_for_bigdecimal branch October 31, 2019 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants