Skip to content

[test] properly 'skip' test on JRuby #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2020
Merged

[test] properly 'skip' test on JRuby #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ rvm:
matrix:
allow_failures:
- rvm: ruby-head
- rvm: jruby-9.1
- rvm: jruby-9.2
- rvm: truffleruby
script: "bundle exec rake"
sudo: false
3 changes: 1 addition & 2 deletions tests/json_generator_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ def silence
end

def test_remove_const_segv
return if RUBY_ENGINE == 'jruby'
stress = GC.stress
const = JSON::SAFE_STATE_PROTOTYPE.dup

Expand All @@ -76,7 +75,7 @@ def test_remove_const_segv
silence do
JSON.const_set :SAFE_STATE_PROTOTYPE, const
end
end if JSON.const_defined?("Ext")
end if JSON.const_defined?("Ext") && RUBY_ENGINE != 'jruby'

def test_generate
json = generate(@hash)
Expand Down