Optimize Symbol generation in strict mode #745
Merged
+86
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etiennebarrie
force-pushed
the
optimize-symbol-generation
branch
from
b3a8d5b to
a43983e
Compare
byroot
force-pushed
the
optimize-symbol-generation
branch
from
a43983e to
1bb591e
Compare
eregon
reviewed
Feb 5, 2025
etiennebarrie
force-pushed
the
optimize-symbol-generation
branch
from
1bb591e to
8e0f3b7
Compare
byroot
force-pushed
the
optimize-symbol-generation
branch
2 times, most recently
from
50a87ba to
4e2078a
Compare
eregon
reviewed
Feb 5, 2025
test/json/json_generator_test.rb
Outdated
| @@ -86,6 +86,9 @@ def test_dump_strict | |||
|
|
|||
| assert_equal '42', dump(42, strict: true) | |||
| assert_equal 'true', dump(true, strict: true) | |||
|
|
|||
| assert_equal '"hello"', dump(:hello, strict: true) | |||
| assert_equal '"World"', dump("World".to_sym, strict: true) | |||
There was a problem hiding this comment.
Probably should test that to_json is not called with strict
There was a problem hiding this comment.
It's somewhat already asserting that because json/add/symbol is loaded in the test suite.
byroot
force-pushed
the
optimize-symbol-generation
branch
from
4e2078a to
d8b0960
Compare
Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
byroot
force-pushed
the
optimize-symbol-generation
branch
from
d8b0960 to
d37638e
Compare
|
FWIW I realized this means |
|
I think that ship has sailed when symbols were accepted as hash keys regardless. But yes, we could chose to do the opposite and reject them in strict mode. One goal of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In strict mode we don't need to check for
to_json, we can just generate a String from a Symbol.It changes behavior because previously Symbol caused a generator error. But keys in hashes already had support for automatic coercion to String, so it feels ok to do.