Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport ruby core changes #44

Merged
merged 3 commits into from
Dec 9, 2019
Merged

Backport ruby core changes #44

merged 3 commits into from
Dec 9, 2019

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Dec 9, 2019

I found the missing commits on http://github.com/ruby/ruby

jeremyevans and others added 2 commits December 9, 2019 18:50
@jeremyevans @hsbt
Fix keyword argument warnings in the tests from Class#new
4436b79 
This were previously hidden because calls from C were not warned.
@hsbt
Fixed LoadError of version file.
df628b1
@sonots
Copy link
Member

sonots commented Dec 9, 2019

thx

@sonots
Copy link
Member

sonots commented Dec 9, 2019

You may merge after ci passed

@hsbt
Copy link
Member Author

hsbt commented Dec 9, 2019

@sonots Thanks!

@hsbt hsbt merged commit a992ce3 into master Dec 9, 2019
@hsbt hsbt deleted the backport-ruby-core branch December 9, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonots sonots sonots approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsbt @sonots @jeremyevans