Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another performance improvement on the Formatter by using Kernel#sprintf over String#% #75

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Another performance improvement on the Formatter by using Kernel#sprintf over String#% #75

merged 2 commits into from
Dec 8, 2022
+2 −3

Commits on Dec 8, 2022

  1. Prefer Kernel#sprintf over String#% for formatting Strings 

    String#% takes the arguments as an Array object, which requires us to create an extra object.
    @amatsuda @ioquatix
    amatsuda authored and ioquatix committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    9af9103 View commit details
    Browse the repository at this point in the history

  2. Cut off one more String allocation 

    Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
    @amatsuda @nobu @ioquatix
    2 people authored and ioquatix committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    bd28656 View commit details
    Browse the repository at this point in the history