Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced RDoc for Logger #76

Merged
merged 8 commits into from
May 13, 2022
Merged

Enhanced RDoc for Logger #76

merged 8 commits into from
May 13, 2022

Conversation

BurdetteLamar
Copy link
Member

Revises the documentation for class Logger. If approved, some adjustments to the doc for methods and attributes will follow.

olleolleolle
olleolleolle reviewed May 12, 2022
View reviewed changes
lib/logger.rb Outdated Show resolved Hide resolved
olleolleolle
olleolleolle reviewed May 12, 2022
View reviewed changes
lib/logger.rb Outdated Show resolved Hide resolved
olleolleolle
olleolleolle reviewed May 12, 2022
View reviewed changes
lib/logger.rb Outdated Show resolved Hide resolved
olleolleolle
olleolleolle reviewed May 12, 2022
View reviewed changes
lib/logger/errors.rb
class Logger
# not used after 1.2.7. just for compat.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

olleolleolle
olleolleolle reviewed May 12, 2022
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have read the change, thanks for making it!

Perhaps someone else has eagle eyes and can take a closer look, but it looks good to me.

BurdetteLamar and others added 3 commits May 12, 2022 09:48
@BurdetteLamar @olleolleolle
Update lib/logger.rb
34c0ba8 
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
@BurdetteLamar @olleolleolle
Update lib/logger.rb
6d91281 
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
@BurdetteLamar @olleolleolle
Update lib/logger.rb
073a892 
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
peterzhu2118
peterzhu2118 reviewed May 12, 2022
View reviewed changes
lib/logger.rb Outdated Show resolved Hide resolved
lib/logger.rb Outdated Show resolved Hide resolved
lib/logger.rb Outdated Show resolved Hide resolved
BurdetteLamar and others added 3 commits May 12, 2022 13:20
@BurdetteLamar @peterzhu2118
Update lib/logger.rb
98919e0 
Co-authored-by: Peter Zhu <peter@peterzhu.ca>
@BurdetteLamar @peterzhu2118
Update lib/logger.rb
3dc5a8d 
Co-authored-by: Peter Zhu <peter@peterzhu.ca>
@BurdetteLamar @peterzhu2118
Update lib/logger.rb
e6f2c64 
Co-authored-by: Peter Zhu <peter@peterzhu.ca>
peterzhu2118
peterzhu2118 reviewed May 12, 2022
View reviewed changes
lib/logger.rb Outdated Show resolved Hide resolved
@BurdetteLamar @peterzhu2118
Update lib/logger.rb
a5a2f2d 
Co-authored-by: Peter Zhu <peter@peterzhu.ca>
peterzhu2118
peterzhu2118 approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@peterzhu2118 peterzhu2118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@BurdetteLamar BurdetteLamar merged commit 00a02e4 into ruby:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterzhu2118 peterzhu2118 peterzhu2118 approved these changes

@olleolleolle olleolleolle Awaiting requested review from olleolleolle

Assignees
No one assigned
Labels
documentation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BurdetteLamar @olleolleolle @peterzhu2118