Merge pull request #200 from ydah/chore2

Remove unnecessary assignments to variables
ruby · Nov 5, 2023 · 871d3bc · 871d3bc
2 parents 259afa3 + be2f834
commit 871d3bc
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 10 deletions.
diff --git a/lib/lrama/context.rb b/lib/lrama/context.rb
@@ -309,10 +309,8 @@ def compute_yydefgoto
       # Index is sequence number of nterm, value is state id
       # of a default nterm transition destination.
       @yydefgoto = Array.new(@states.nterms.count, 0)
-      h = {}
       # Mapping from nterm to next_states
       nterm_to_next_states = {}
-      terms_count = @states.terms.count
 
       @states.states.each do |state|
         state.nterm_transitions.each do |shift, next_state|

diff --git a/lib/lrama/grammar/code/initial_action_code.rb b/lib/lrama/grammar/code/initial_action_code.rb
@@ -11,9 +11,9 @@ class InitialActionCode < Code
         def reference_to_c(ref)
           case
           when ref.type == :dollar && ref.value == "$" # $$
-            str = "yylval"
+            "yylval"
           when ref.type == :at && ref.value == "$" # @$
-            str = "yylloc"
+            "yylloc"
           when ref.type == :dollar # $n
             raise "$#{ref.value} can not be used in initial_action."
           when ref.type == :at # @n

diff --git a/lib/lrama/grammar/code/printer_code.rb b/lib/lrama/grammar/code/printer_code.rb
@@ -17,9 +17,9 @@ def reference_to_c(ref)
           case
           when ref.type == :dollar && ref.value == "$" # $$
             member = @tag.member
-            str = "((*yyvaluep).#{member})"
+            "((*yyvaluep).#{member})"
           when ref.type == :at && ref.value == "$" # @$
-            str = "(*yylocationp)"
+            "(*yylocationp)"
           when ref.type == :dollar # $n
             raise "$#{ref.value} can not be used in #{type}."
           when ref.type == :at # @n

diff --git a/lib/lrama/grammar/code/rule_action.rb b/lib/lrama/grammar/code/rule_action.rb
@@ -12,16 +12,16 @@ def reference_to_c(ref)
           case
           when ref.type == :dollar && ref.value == "$" # $$
             member = ref.tag.member
-            str = "(yyval.#{member})"
+            "(yyval.#{member})"
           when ref.type == :at && ref.value == "$" # @$
-            str = "(yyloc)"
+            "(yyloc)"
           when ref.type == :dollar # $n
             i = -ref.position_in_rhs + ref.value
             member = ref.tag.member
-            str = "(yyvsp[#{i}].#{member})"
+            "(yyvsp[#{i}].#{member})"
           when ref.type == :at # @n
             i = -ref.position_in_rhs + ref.value
-            str = "(yylsp[#{i}])"
+            "(yylsp[#{i}])"
           else
             raise "Unexpected. #{self}, #{ref}"
           end