add lexer/token/type.rbs #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Thank you! |
yui-knk
reviewed
Oct 12, 2023
| attr_accessor type: Type | ||
| attr_accessor s_value: String | ||
| attr_accessor alias: String | ||
| attr_accessor keyword_init: bool |
There was a problem hiding this comment.
keyword_init of Struct.new doesn't define keyword_init accessor on the class it creates, I noticed it after merge.
Could you remove this type definition when you have chance?
>> s = Struce.new(:a, keyword_init: true)
>> s.new(a: 1).a
=> 1
>> s.new(a: 1).keyword_init
(irb):6:in `<main>': undefined method `keyword_init' for an instance of #<Class:0x0000000105b9df38>(keyword_init: true) (NoMethodError)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was planning to type-check
symbol.rb, but I realized that I needgrammar.rb,lexer/token.rb, andlexer/token/type.rb.I'm working on preparing them in order, and this is going to be the first step in that process.