Add support for Parameterizing rules with zero parameters #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, Inline does not specify parameters. Inline is implemented as an option to Parameterizing rules. Therefore, we added support for Parameterizing rules with zero parameters.
yui-knk
reviewed
Mar 28, 2024
| @@ -231,7 +231,12 @@ rule | |||
|
|
|||
| token_declaration: id int_opt alias { result = val } | |||
|
|
|||
| rule_declaration: "%rule" IDENTIFIER "(" rule_args ")" ":" rule_rhs_list | |||
| rule_declaration: "%rule" id_colon ":" rule_rhs_list | |||
There was a problem hiding this comment.
I think %rule without %inline is needless because it is same with
a normal production rule.
I agree to introducing zero parameters for %inline but it might be better to support the feature in #369.
There was a problem hiding this comment.
Indeed it is. So I close this PR. Thank you for your review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, Inline does not specify parameters. Inline is implemented as an option to Parameterizing rules.
Therefore, we added support for Parameterizing rules with zero parameters.