Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some rbs #437

Merged
merged 3 commits into from
Jun 9, 2024
Merged

Fix some rbs #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bab225
Fix an indentation in sig/lrama/options.rbs
ydah Jun 7, 2024
e9df5fc
Fix rbs validate warning
ydah Jun 7, 2024
0f2d99a
Use void instead of bot?
ydah Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sig/lrama/grammar.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ module Lrama
def epilogue_first_lineno=: (Integer epilogue_first_lineno) -> Integer
def epilogue=: (String epilogue) -> String
def prepare: () -> void
def validate!: () -> (void | bot)
def validate!: () -> void
def find_rules_by_symbol!: (Grammar::Symbol sym) -> Array[Rule]
def find_rules_by_symbol: (Grammar::Symbol sym) -> Array[Rule]?

Expand All @@ -88,6 +88,6 @@ module Lrama
def fill_default_precedence: () -> void
def fill_symbols: () -> Array[Grammar::Symbol]
def fill_sym_to_rules: () -> Array[Rule]
def validate_rule_lhs_is_nterm!: () -> bot?
def validate_rule_lhs_is_nterm!: () -> void
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

memo) The bot is used for methods that either always throw an exception or enter an infinite loop and never terminate. Therefore, I believe void is correct here.

end
end
4 changes: 2 additions & 2 deletions sig/lrama/options.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module Lrama
class Options
class Options
attr_accessor skeleton: String
attr_accessor header: bool
attr_accessor header_file: String?
Expand All @@ -13,5 +13,5 @@ module Lrama
attr_accessor debug: bool

def initialize: () -> void
end
end
end