Replace parser with one made by Racc #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| while !scanner.eos? do | ||
| start = scanner.pos | ||
| case | ||
| when scanner.scan(/\$(<[a-zA-Z0-9_]+>)?\$/) # $$, $<long>$ |
There was a problem hiding this comment.
If don't need to use the result of scan, you can try to use skip and save a lot of allocations and improve the performance
There was a problem hiding this comment.
Similar what I did in this PR #102
junk0612
force-pushed
the
use-racc
branch
2 times, most recently
from
f7ae7f6 to
c9f0cfd
Compare
junk0612
changed the title
|
|
|
I'm excited to merge this PR! Greatly appreciate your hard work 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate the parser of grammar file with Racc and replace it from original parser.
TODOs
parse.yReplace the parser with the original