Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new configuration to preserve headers case #146

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

AllanSiqueira
Copy link

Issue: #143

  • Add new configuration to preserve headers case in Net::HTTP class
  • Add new configuration to preserve headers case in GenericRequest class

@AllanSiqueira AllanSiqueira marked this pull request as ready for review August 19, 2023 04:58
- Add new configuration to preserve headers case in Net::HTTP class
- Add new configuration to preserve headers case in GenericRequest class
Copy link
Member

@nobu nobu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name doesn’t feel nice to me.
What of headers does it preserve?

@AllanSiqueira
Copy link
Author

The name doesn’t feel nice to me. What of headers does it preserve?

Great, what do you think we call it capitalize_headers, make it default true.

@nobu
Copy link
Member

nobu commented Nov 1, 2023

The name doesn’t feel nice to me. What of headers does it preserve?

Great, what do you think we call it capitalize_headers, make it default true.

It sounds fine.

@AllanSiqueira
Copy link
Author

Done the changes, when you have the time, may you review it again @nobu ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants