Skip to content

preventing hang when TCPSocket readable, but no app-data is available #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −4
Open

preventing hang when TCPSocket readable, but no app-data is available #232

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f525ef6
preventing hang when io readable, but no app-data
dotconfig404 Oct 20, 2025
2cdcab2
fix typo: read_nonblock call on SSLSocket
dotconfig404 Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions lib/net/http.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2462,10 +2462,13 @@ def begin_transport(req)
debug 'Conn close because of keep_alive_timeout'
@socket.close
connect
elsif @socket.io.to_io.wait_readable(0) && @socket.eof?
debug "Conn close because of EOF"
@socket.close
connect
end
while @socket.io.to_io.wait_readable(0)
if @socket.io.read_nonblock(1, exception: false) == nil
debug "Conn close because of EOF"
@socket.close
connect
end
end
end

Expand Down