[DOC] New doc for responses classes #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| class HTTPUnknownResponse < HTTPResponse | ||
| HAS_BODY = true | ||
| EXCEPTION_TYPE = HTTPError # |
There was a problem hiding this comment.
I realize that this isn't in scope of your PR, but do you know why these lines have an empty comment at the end of the line?
lib/net/http/responses.rb
Outdated
|
|
||
| # Response class for <tt>Conflict</tt> responses (status code 409). | ||
| # | ||
| # The request could not be processed because of conflict in the current state of the resource |
There was a problem hiding this comment.
You're missing a period for this line.
Suggested change
| # The request could not be processed because of conflict in the current state of the resource | |
| # The request could not be processed because of conflict in the current state of the resource. |
peterzhu2118
approved these changes
Dec 14, 2022
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents subclasses of Net::HTTPResponse (removing :nodoc: and adding text), with a link
to a Wikipedia section for each. This also enables autolinking from HTTPResponse.html to those subclasses.