🚚 Move and rename SASL authenticators #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original constants for the `PLAIN` and `XOAUTH2` authenticators are now deprecated aliases. The constants for deprecated mechanisms were simply moved, with no regard for backward compatibility.
The original methods (`Net::IMAP.authenticator` and `Net::IMAP.add_authenticator`) both still work, by delegation to the new methods. But they have been deprecated and will issue warnings.
This was referenced Sep 7, 2023
Merged
nevans
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Net::IMAP#authenticatestill behaves identically to beforeNet::IMAP::PlainAuthenticatorandNet::IMAP::Xoauth2Authenticatorhave been moved toNet::IMAP::SASL::PlainAuthenticatorandNet::IMAP::SASL::XOAuth2Authenticator. The original constants still work but are deprecated.Net::IMAP::DigestMD5Authenticator,Net::IMAP::LoginAuthenticator, andNet::IMAP::CramMD5Authenticatorwere also moved toNet::IMAP::SASL. The original constants have simply been removed.Net::IMAP::Authenticatorshas also been moved toNet::IMAP::SASLand has been converted to a class (with a default global instance). The original mixin module still exists and delegates toNet::IMAP::SASL, but it is deprecated.