-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract authenticators to their own files #22
Conversation
Also updates rdoc with SASL specifications and deprecations. Of these four, only `PLAIN` isn't deprecated! +@@Authenticators+ was changed to a class instance var +@Authenticators+. No one should have been using the class variable directly, so that should be fine.
* Add authzid support * must not contain NULL chars * improve rdoc
Added RFC links to all SASL mechanism specifications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
@hsbt Do you have any considerations in terms of Ruby releases?
👍 It seems good practice for organizing code. @nevans Can you also move |
If we move the gemspec, won't that break existing build scripts? In particular, it means that people won't be able to use the common pattern: |
And... I only just discovered that bundler's default glob is |
Ah, Sorry. I meant it in |
I tweaked sync script at ruby/ruby@5de6f1a |
I've started down the path of implementing #10. This PR simply copies authenticators with some minor changes, but this raises a big issue I've been meaning to ask about: SASL. I'll open another issue to discuss that: #23. I'm marking this as a draft, pending that discussion.
In addition to moving the authenticators to new files, I've updated the rdoc and added
authnid
support forPLAIN
.