Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add support for the CONDSTORE extension (RFC7162) #236

Merged
merged 8 commits into from
Dec 12, 2023

Conversation

nevans
Copy link
Collaborator

@nevans nevans commented Nov 22, 2023

NOTE: Both #search and #uid_search have been updated to return SearchResult rather than Array. SearchResult inherits from Array, for backward compatibility.

Similarly, the MODIFIED response code on the tagged response to #store and #uid_store is currently only accessible by using a response handler: response code data on tagged responses isn't saved to #responses. Unlike with the search methods returning SearchResult, I did not change the behavior of #store to return a new result object inheriting from Array. IMO, that change would require a backward compatibility config option and a deprecation period.

@nevans nevans force-pushed the CONDSTORE-extension branch 5 times, most recently from a01cbd2 to 4d6acf1 Compare November 25, 2023 14:26
@nevans nevans force-pushed the CONDSTORE-extension branch 6 times, most recently from d465a46 to ccb6fa0 Compare December 1, 2023 23:19
@nevans nevans force-pushed the CONDSTORE-extension branch 3 times, most recently from d8fc0c9 to 4b72d03 Compare December 11, 2023 06:37
@nevans nevans marked this pull request as ready for review December 11, 2023 06:40
@nevans nevans force-pushed the CONDSTORE-extension branch 2 times, most recently from 2ff6f5f to fbe8eca Compare December 11, 2023 15:29
@nevans nevans requested a review from shugo December 11, 2023 23:40
This doesn't actually require explicit support, because `HIGHESTMODSEQ`
is simply another numeric status attribute, and we already parse
`number` as the default (without using `ExtensionData`).
Previously, MODSEQ was parsed but ignored.  SearchResult inherits from
Array, to preserve backwards compatibility.
* `NOMODSEQ` _(already previously supported)_
* `HIGHESTMODSEQ`
* `MODIFIED`
Note that QRESYNC isn't actually supported yet, so `VANISHED` responses
are parsed as `response_data__unhandled`, which simply returns a string
wrapped in `UnparsedData`.
@nevans nevans merged commit 605570b into ruby:master Dec 12, 2023
11 checks passed
@nevans nevans deleted the CONDSTORE-extension branch December 12, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

RFC7162 (2014): CONDSTORE (recommended by IMAP4rev2)
1 participant