Make #auth_capable? public
#63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 9, 2023
This can be useful to users of the library, in the same way that `#capable?`, `#capabilities`, and `#capable_auth_types` are all useful. I suggest deprecating the specific mechanism predicate methods (`capable_plain_auth?`, `capable_login_auth?`, and `capable_cram_md5_auth?`), as they are all replaced by this.
nevans
force-pushed
the
sasl/public-auth_capable
branch
from
66553b0
to
6d51323
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be useful to users of the library, in the same way that
#capable?,#capabilities, and#capable_auth_typesare all useful. For what it's worth#auth_capable?is public fornet-imapv0.4.0.I will also suggest that perhaps some future version should deprecate (and eventually, remove) the specific mechanism predicate methods (
capable_plain_auth?,capable_login_auth?, andcapable_cram_md5_auth?). A new predicate method shouldn't be added for every potential SASL mechanism.