Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version extraction to work with non ASCII characters with any LANG #76

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Jan 4, 2024

d9fe72a introduced a non-ASCII character (U+2014) in comment but Regex match failed with non UTF-8 locale.

The extraction failure results in the following build error while building ruby with gems/bundled_gems including git-revision specified net-smtp.

Building net-smtp@2b251244b7678c5e84e620584c26242f36c1e91a to gems/net-smtp-0.4.0.gem
Invalid gemspec in [net-smtp.gemspec]: undefined method `prerelease?' for nil:NilClass
Failed to load gems/src/net-smtp/net-smtp.gemspec

https://rubyci.s3.amazonaws.com/debian-riscv64/ruby-master/log/20240104T070017Z.fail.html.gz

This commit fixes it by specifying encoding explicitly.

d9fe72a introduced a non-ASCII character (U+2014) in comment but
Regex match failed with non UTF-8 locale.

This commit fixes it by specifying encoding explicitly.
@hsbt hsbt merged commit 809a87d into ruby:master Jan 4, 2024
12 checks passed
kateinoigakukun added a commit to kateinoigakukun/ruby that referenced this pull request Jan 4, 2024
kateinoigakukun added a commit to kateinoigakukun/ruby that referenced this pull request Jan 4, 2024
@kateinoigakukun kateinoigakukun deleted the katei/fix-version-extraction branch January 4, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants