Merge pull request #585 from Maumagnaguagno/refactor-buffering-methods

Refactor Buffering consume_rbuff and getbyte methods
ruby · Aug 31, 2023 · 2dc1253 · 2dc1253
2 parents 5ccd76c + 5f6abff
commit 2dc1253
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/lib/openssl/buffering.rb b/lib/openssl/buffering.rb
@@ -93,9 +93,7 @@ def consume_rbuff(size=nil)
       nil
     else
       size = @rbuffer.size unless size
-      ret = @rbuffer[0, size]
-      @rbuffer[0, size] = ""
-      ret
+      @rbuffer.slice!(0, size)
     end
   end
 
@@ -106,8 +104,7 @@ def consume_rbuff(size=nil)
   #
   # Get the next 8bit byte from `ssl`.  Returns `nil` on EOF
   def getbyte
-    byte = read(1)
-    byte && byte.unpack1("C")
+    read(1)&.ord
   end
 
   ##