Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document support for SNI #81

Closed
cknowles opened this issue Oct 31, 2016 · 2 comments
Closed

Document support for SNI #81

cknowles opened this issue Oct 31, 2016 · 2 comments

Comments

@cknowles
Copy link

The current documentation does not list any support for SNI although it can be done as OpenSSL::SSL::SSLSocket#hostname= and is referenced in #8. Is it officially supported?

In openssl, it can be done via -servername HOST so the naming does not match and hence it would be good to get it documented. Note, I found this via stackoverflow.

Given that the code wraps the attribute in if ExtConfig::HAVE_TLSEXT_HOST_NAME, I'm not sure about the best way to get this appearing in rdoc.

@rhenium
Copy link
Member

rhenium commented Oct 31, 2016

Yes, it is part of the public API, since Ruby 1.9.2 (note it requires OpenSSL >= 0.9.8f).

RDoc comment was fixed some time ago, and OpenSSL::SSL::SSLSocket#hostname= now shows up in the latest HTML generated from the master branch:

http://ruby.github.io/openssl/OpenSSL/SSL/SSLSocket.html#method-i-hostname-3D

@rhenium rhenium closed this as completed Oct 31, 2016
@cknowles
Copy link
Author

Great, thanks! Those docs are definitely nicer than the ones currently on ruby-doc.org.

glaszig added a commit to glaszig/logstash-logger that referenced this issue Mar 1, 2017
this will allow the usage of the SSLSocket#hostname property
to configure SNI (ruby/openssl#81).

also, we do hostname verification ourselves (post_connection_check) to
1. don't have different behavior with different ruby versions
2. have one interface for all ruby versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants