Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp support #204

Merged
merged 18 commits into from
Sep 30, 2019
Merged

Timestamp support #204

merged 18 commits into from
Sep 30, 2019

Commits on Sep 27, 2019

  1. ts: Timestamp support (1/3)

    This commit applies the initial patches (ts.tar.gz) from https://bugs.ruby-lang.org/issues/4183
    
    This compiles with several warnings. Tests don't run yet.
    emboss authored and btoews committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    c984360 View commit details
    Browse the repository at this point in the history
  2. ts: Timestamp support (2/3)

    This commit applies the second patches (ts2.tar.gz) from https://bugs.ruby-lang.org/issues/4183
    emboss authored and btoews committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    285bd40 View commit details
    Browse the repository at this point in the history
  3. ts: Timestamp support (3/3)

    This commit applies the third patches (tsr3.tar.gz) from https://bugs.ruby-lang.org/issues/4183
    emboss authored and btoews committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    16b80b2 View commit details
    Browse the repository at this point in the history
  4. ts: get tests running/passing

    A number of conventions seem to have changed, causing a fair bit of breakage:
      - `Data_*` was deprecated in favor of `TypedData_*`
      - `ossl_obj2bio` takes a `VALUE*` instead of `VALUE` now
      - `time_to_time_t()` was removed
    btoews committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    f15cd66 View commit details
    Browse the repository at this point in the history
  5. ts: update to work with openssl 1.1.x

    - clean up whitespace
    - be consistent with not returning after ossl_raise
    - use accessor functions when working with openssl TS_* structs
    - backport accessors for TS_STATUS_INFO, TS_VERIFY_CTX, and TS_RESP_CTX as macros
    btoews committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    96501f2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e03e6bf View commit details
    Browse the repository at this point in the history
  7. ts: clean up some memory leaks

    btoews committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    221241c View commit details
    Browse the repository at this point in the history
  8. ts: fix for libressl

    - define missing TS_RESP_CTX_set_time_cb
    - handle alternate case for nil oid
    btoews committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    ed44b34 View commit details
    Browse the repository at this point in the history
  9. ts: fix windows build

    btoews committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    c7e2514 View commit details
    Browse the repository at this point in the history
  10. ts: address minor feedback from rhenium (more changes coming)

    - make some global variables static instead of extern
    - get rid of GetTsReqPtr/GetTsRespPtr functions
    - don't use c99 comments
    - fix some leaks
    - clarify what numeric type is returned (Integer or BN, never Fixnum)
    - typos
    - add missing checks, remove unecessary checks
    - use OPENSSL_NO_TS instead of our own macros checking for ts support
    - use EVP_{digest-name} instead of looking up algos by NID
    - don't differentiate between failure reasons when verifying
    - rename Response#pkcs7 to #token
    btoews committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    d0f6fd7 View commit details
    Browse the repository at this point in the history
  11. ts: simplify TimestampResponse#response signature

    This method allowed roots and intermediates to be specified in a number of ways.
    This complexity wasn't super valuable though and its better to only allow an
    X509::Store with an optional Array of intermediates. This greatly simplifies
    the code and fixes a few leaks.
    btoews committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    8eacc80 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    154c5f5 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    8a705bf View commit details
    Browse the repository at this point in the history
  14. ts: fix another leak

    btoews committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    da9cc7e View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    f9be45d View commit details
    Browse the repository at this point in the history
  16. ts: address more feedback

    btoews committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    f2824e0 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    e832b8c View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2019

  1. expand tabs

    btoews committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    75700f1 View commit details
    Browse the repository at this point in the history