Retry add_certificate_chain_file changes #325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 23b0704.
|
It's good to reproduce test fails same as ruby repo at https://github.com/ruby/openssl/pull/325/checks?check_run_id=448254316 |
|
I’m not sure why we reverted this on master and then made a pr to revert that. Was it just to show test failures? |
|
It’s a little bit risky to revert a change on master because people are using master branch with new features... |
@ioquatix Yes. This pr is a working branch for the new feature. We can fix this branch with mswin platform if we hope to add the |
|
Closing in favor of #441 (merged last year). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @ioquatix
This reverts commit 23b0704.
Fixes #318