CI: Add OpenSSL master branch head non-FIPS and FIPS cases. #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junaruga
force-pushed
the
wip/ci-openssl-head
branch
from
adc7ba9
to
40323bb
Compare
junaruga
commented
Aug 8, 2023
| @@ -93,17 +93,28 @@ jobs: | |||
| include: | |||
| - { os: ubuntu-latest, ruby: "3.0", openssl: openssl-3.0.10, fips-enabled: true, append-configure: 'enable-fips', name-extra: 'fips' } | |||
| - { os: ubuntu-latest, ruby: "3.0", openssl: openssl-3.1.2, fips-enabled: true, append-configure: 'enable-fips', name-extra: 'fips' } | |||
| - { os: ubuntu-latest, ruby: "3.0", openssl: openssl-head, git: 'git://git.openssl.org/openssl.git', branch: 'master' } | |||
| - { os: ubuntu-latest, ruby: "3.0", openssl: openssl-head, git: 'git://git.openssl.org/openssl.git', branch: 'master', fips-enabled: true, append-configure: 'enable-fips', name-extra: 'fips' } | |||
There was a problem hiding this comment.
For the added new hash keys git and branch, I referred to the syntax of Bundler's Gemfile using the git and branch for similar purpose. - https://bundler.io/guides/git.html
|
You can see the added "openssl-head" and "openssl-head fips" cases in the following log. You can also check the printed "OpenSSL 3.2.0-dev" by |
rhenium
reviewed
Aug 8, 2023
To confirm if the Ruby OpenSSL works on the OpenSSL master branch non-FIPS and FIPS cases that may include some bug fixes or new features.
junaruga
force-pushed
the
wip/ci-openssl-head
branch
from
40323bb
to
7ec8024
Compare
|
@rhenium Rebasing this PR, with removing the |
|
Looks good to me! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add the cases to test Ruby OpenSSL binding (ruby/openssl) on OpenSSL master branch non-FIPS and FIPS cases.
Motivation
My motivation for this PR is that we can immediately test Ruby OpenSSL binding with the OpenSSL where a PR to fix the issues related to our unit test was merged. There is a time lag until the next OpenSSL stable version including the fixes.
I reported one issue openssl/openssl#21493 that caused some test failures in our unit test in FIPS case to the OpenSSL project (openssl/openssl), and the PR openssl/openssl#21519 (comment) fixing the issue was merged to the
masterbranch (openssl-3.2.0-dev), (andopenssl-3.1andopenssl-3.0branches too) recently. Adding these CI cases by this PR, I can check the Ruby OpenSSL binding's unit tests on the fixed versions of the OpenSSL.Description
I added an option to download OpenSSL from their Git repository. I added the
set -xto enable Bash debugging option andset +xto disable Bash debugging option. Because it was convenient to debug the bash script error, and it is convenient to check which commands are actually executed in the CI log.