Fix CI in maint-3.1 branch #846
Merged
+14
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ This is a backport to the 3.1 branch. ] This is a squash of the following commits, and brings the content of Gemfile to match master: b0acc1a Make optional benchmark test in OpenSSL::OSSL#test_memcmp_timing 4312b07 Add rdoc as a development dependency. f59ec58 Use the test-unit-ruby-core gem for Test::Unit::CoreAssertions 459f20b Add prime gem to development dependency
The benchmark library is planned to become a bundled gem in Ruby 3.5. While we can add it in our Gemfile, it is only used in test_memcmp_timing and the usage can be easily replaced with a few Process.clock_gettime calls.
The :development group is pointless because Gemfile is relevant for those who run ruby/openssl tests in this repository only, and not included in the gem package. Let's list the test dependency in the top level. The rdoc library is now a bundled gem in Ruby master, not just in Fedora's Ruby distributions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.