Officially drop support for ruby 2.6 or older #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
CI should be fixed once I finish ruby/rubygems#4992 and release it. |
The gem doesn't even install on old rubies, but since the gemspec claims it's supported, `gem install pathname` will try to install it and print an error. This commit doesn't fix the above issue. The only way to fix it would be to restore support and release a new version that actually supports old rubies. However, such a change has been proposed and ignored for a long time. So this issue proposes to leave that broken but at least bring the gemspec manifest and the CI matrix in sync to hopefully avoid this issue from happening again in the future.
deivid-rodriguez
force-pushed
the
remove_ruby_2_6_support
branch
from
2f280a4 to
3ee010b
Compare
|
I released a new version of bundler that I think should fix the previous CI issue. So hopefully CI is now green. |
|
Oh nevermind. In this case, |
|
Fine with JRuby since we never supported the C extension in this gem. JRuby will need to be added in a separate PR for our Ruby 3.0-compatible release (JRuby 9.4). |
|
I will look this after releasing Ruby 3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gem doesn't even install on old rubies, but since the gemspec claims it's supported,
gem install pathnamewill try to install it and print an error.This commit doesn't fix the above issue. The only way to fix it would be to restore support and release a new version that actually supports old rubies. However, such a change has been proposed and ignored for a long time. Also I noticed that deprecating taint/untaint was done without considering old rubies, so I think it's clear that maintainers don't want to support ruby 2.6.
So this issue proposes to leave that broken but at least bring the gemspec manifest and the CI matrix in sync to hopefully avoid this issue from happening again in the future.