Don't use make
while building Prism
#3289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit teaches mkmf about the libprism sources and allows it to compile them directly
Fixes #3273
I was able to teach
mkmf
about thelibprism
source files without copying them in to the ext folder. The code isn't particularly nice, you have to know about global variables internal tomkmf
, but it does eliminate callingmake
during the gem build process.@mame do you think this will work on mswin64? I don't have a machine handy to test with.