Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use make while building Prism #3289

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Don't use make while building Prism #3289

merged 2 commits into from
Dec 5, 2024

Conversation

tenderlove
Copy link
Member

This commit teaches mkmf about the libprism sources and allows it to compile them directly

Fixes #3273

I was able to teach mkmf about the libprism source files without copying them in to the ext folder. The code isn't particularly nice, you have to know about global variables internal to mkmf, but it does eliminate calling make during the gem build process.

@mame do you think this will work on mswin64? I don't have a machine handy to test with.

@tenderlove tenderlove force-pushed the nomake branch 2 times, most recently from ec1e844 to 9e49fa7 Compare December 5, 2024 01:07
This commit teaches mkmf about the libprism sources and allows it to
compile them directly

Fixes #3273
@mame
Copy link
Member

mame commented Dec 5, 2024

I confirmed that a custom-built prism gem with your patch worked well on my windows. Thank you!

C:\Users\YusukeEndoh>.\ruby\local\bin\gem install prism-1.2.0.gem
Building native extensions. This could take a while...
Successfully installed prism-1.2.0
Ignoring prism-0.27.0 because its extensions are not built. Try: gem pristine prism --version 0.27.0
Parsing documentation for prism-1.2.0
Installing ri documentation for prism-1.2.0
Done installing documentation for prism after 37 seconds
1 gem installed

@tenderlove tenderlove merged commit 49c0cba into main Dec 5, 2024
56 checks passed
@tenderlove tenderlove deleted the nomake branch December 5, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to install gem on mswin64
3 participants