Fix ArgumentError with leading and trailing underscores in number str… #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a question about this one. What's the lowest version of Ruby that this bug is fixed for? This bug seems to be present for me in Ruby 2.7.3 and 2.7.4 but not 3.0.2. Is this bug fix in any 2.7.x or do you have to upgrade to 3.x to get the fix? |
No you can simply add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ings.
001:0> require 'psych'
true
002:0> '123_'.to_yaml
Traceback (most recent call last):
...
4: from .../lib/ruby/2.7.0/psych/visitors/yaml_tree.rb:279:in
visit_String' 3: from .../lib/ruby/2.7.0/psych/scalar_scanner.rb:95:intokenize'2: from .../lib/ruby/2.7.0/psych/scalar_scanner.rb:104:in
parse_int' 1: from .../lib/ruby/2.7.0/psych/scalar_scanner.rb:104:inInteger'ArgumentError (invalid value for Integer(): "123_")
003:0> '0x_123'.to_yaml
Traceback (most recent call last):
...
4: from .../lib/ruby/2.7.0/psych/visitors/yaml_tree.rb:279:in
visit_String' 3: from .../lib/ruby/2.7.0/psych/scalar_scanner.rb:95:intokenize'2: from .../lib/ruby/2.7.0/psych/scalar_scanner.rb:104:in
parse_int' 1: from .../lib/ruby/2.7.0/psych/scalar_scanner.rb:104:inInteger'ArgumentError (invalid value for Integer(): "0x_123")