-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rdoc enhancements for psych.rb #468
base: master
Are you sure you want to change the base?
Conversation
@hsbt, I've requested a review from you because you're the frequent contributor in recent history. Let me know if you'd like me to request someone else. |
@hsbt, should I ask someone else to review? |
@hsbt, I think this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change, in that it strengthens the "general section" which provides a complete narrative, for the learner/reader.
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ✨ good ✨ to me!
@hsbt, @olleolleolle has reviewed and approved this PR. Ok to merge? I'm reluctant without hearing from you. |
@tenderlove, would appreciate a blessing from you or @hsbt before merging this. |
@BurdetteLamar You ignored our feedback at ruby/ruby#3506 (comment) Because I couldn't/will not approve your pull-request. |
@tenderlove, you are a maintainer here? Can you (or someone) review this? |
This PR concerns primarily the high-level interface:
This PR is larger than I would have liked, but the high-level API concepts are intertwined, and the their doc needs to be modified all at once.