Add strict_integer option to parse numbers with commas as strings #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authored-by: Seth Boyles <sethboyles@gmail.com>
tenderlove
approved these changes
Jan 22, 2022
|
Thanks for the merge! Any idea when we will see this released? |
ceritium
added a commit
to ceritium/flatito
that referenced
this pull request
Mar 15, 2024
Remove the option strict_integer, it was introduced on Ruby 3.2.0 but we don't really need it. Removing it, we make the code compatible from 3.0.0 to 3.2.0 at least. Related MR: ruby/psych#537
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #273
This PR introduces a
strict_integeroption to the load/parsing methods, allowing for closer adherence to the YML spec, which specifies that numbers including commas should be parsed as strings. More details in the above linked issue.