Stop compressing integer lists #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is unclear why this was implemented, I assume it was for performance back in 2006. However today, this compression defeats bytecode caching entirely and end up being counter productive.
|
It seems a reasonable. But I'm not sure why it's added with the historical reason. |
Yes, I tried to find some reasoning in the git history, but got stuck at this stage: https://github.com/ruby/racc/blame/fa7cc077e37f879cc56546aafb42b502c82f7e91/output.rb#L265 Maybe it was simply to reduce the generated code size? It's true that my PRT makes the output much less compact, but IMHO that's not what we should be optimizing for. |
I agree. This seems fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unclear why this was implemented, I assume it was for performance back in 2006.
However today, this compression defeats bytecode caching entirely and end up being counter productive.
cc @tenderlove