Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop old ruby versions which are no longer tested #325

Merged
merged 2 commits into from
Sep 2, 2019
Merged

Drop old ruby versions which are no longer tested #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d745f8
Drop old ruby versions which are no longer tested
nobu Aug 31, 2019
a24f841
Removed stale skips
nobu Aug 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rake.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Rake has the following features:
s.executables = s.files.grep(%r{^exe/}) { |f| File.basename(f) }
s.require_paths = ["lib".freeze]

s.required_ruby_version = Gem::Requirement.new(">= 2.0.0".freeze)
s.required_ruby_version = Gem::Requirement.new(">= 2.2".freeze)
s.rubygems_version = "2.6.1".freeze
s.required_rubygems_version = Gem::Requirement.new(">= 1.3.2".freeze)
s.rdoc_options = ["--main".freeze, "README.rdoc".freeze]
Expand Down
3 changes: 0 additions & 3 deletions test/test_rake_application.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,6 @@ def test_display_exception_details_bad_encoding
end

def test_display_exception_details_cause
skip "Exception#cause not implemented" unless
Exception.method_defined? :cause

begin
raise "cause a"
rescue
Expand Down
2 changes: 0 additions & 2 deletions test/test_rake_backtrace.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ def test_bin_rake_suppressed

def test_system_dir_suppressed
path = RbConfig::CONFIG["rubylibprefix"]
skip if path.nil?
path = File.expand_path path

paths = [path + ":12"]
Expand All @@ -25,7 +24,6 @@ def test_system_dir_suppressed

def test_near_system_dir_isnt_suppressed
path = RbConfig::CONFIG["rubylibprefix"]
skip if path.nil?
path = File.expand_path path

paths = [" " + path + ":12"]
Expand Down
1 change: 0 additions & 1 deletion test/test_rake_file_list.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,6 @@ def test_exclude_with_string_return_on_create
end

def test_exclude_curly_bracket_pattern
skip "brace pattern matches not supported" unless defined? File::FNM_EXTGLOB
fl = FileList["*"].exclude("{abc,xyz}.c")
assert_equal %w[abc.h abc.x cfiles existing x.c xyzzy.txt], fl
end
Expand Down
3 changes: 0 additions & 3 deletions test/test_rake_task_with_arguments.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,6 @@ def test_actions_of_various_arity_are_ok_with_args
end

def test_actions_adore_keywords
# A brutish trick to avoid parsing. Remove it once support for 1.9 and 2.0 is dropped
# https://ci.appveyor.com/project/ruby/rake/build/1.0.301
skip "Keywords aren't a feature in this version" if RUBY_VERSION =~ /^1|^2\.0/
# https://github.com/ruby/rake/pull/174#issuecomment-263460761
skip if jruby9?
eval <<-RUBY, binding, __FILE__, __LINE__+1
Expand Down