Use Struct instead of OpenStruct. #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I will migrate osturct as bundled gems at Ruby 3.5. We should remove its dependency from Rake
hsbt
force-pushed
the
remove-ostrust-dependency
branch
from
dcb5c1c to
a27bb8e
Compare
xjunior
referenced
this pull request
in powerhome/audiences
Apr 8, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [rake](https://togithub.com/ruby/rake) ([changelog](https://togithub.com/ruby/rake/blob/v13.2.1/History.rdoc)) | `13.1.0` -> `13.2.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ruby/rake (rake)</summary> ### [`v13.2.1`](https://togithub.com/ruby/rake/releases/tag/v13.2.1) [Compare Source](https://togithub.com/ruby/rake/compare/v13.2.0...v13.2.1) #### What's Changed - Suppressed "<internal:array>:52:in 'Array#each'" from backtrace by [@​hsbt](https://togithub.com/hsbt) in [https://github.com/ruby/rake/pull/554](https://togithub.com/ruby/rake/pull/554) - Bump actions/configure-pages from 4 to 5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/ruby/rake/pull/553](https://togithub.com/ruby/rake/pull/553) **Full Changelog**: ruby/rake@v13.2.0...v13.2.1 ### [`v13.2.0`](https://togithub.com/ruby/rake/releases/tag/v13.2.0) [Compare Source](https://togithub.com/ruby/rake/compare/v13.1.0...v13.2.0) #### What's Changed - Fix rule example to be correct by [@​zenspider](https://togithub.com/zenspider) in [https://github.com/ruby/rake/pull/525](https://togithub.com/ruby/rake/pull/525) - Switch to use test-unit by [@​hsbt](https://togithub.com/hsbt) in [https://github.com/ruby/rake/pull/536](https://togithub.com/ruby/rake/pull/536) - Removed redundant block by [@​hsbt](https://togithub.com/hsbt) in [https://github.com/ruby/rake/pull/537](https://togithub.com/ruby/rake/pull/537) - Use Struct instead of OpenStruct. by [@​hsbt](https://togithub.com/hsbt) in [https://github.com/ruby/rake/pull/545](https://togithub.com/ruby/rake/pull/545) - Accept FileList object as directory task's target by [@​gemmaro](https://togithub.com/gemmaro) in [https://github.com/ruby/rake/pull/530](https://togithub.com/ruby/rake/pull/530) - Fix exception when exception has nil backtrace by [@​janbiedermann](https://togithub.com/janbiedermann) in [https://github.com/ruby/rake/pull/451](https://togithub.com/ruby/rake/pull/451) - Add TruffleRuby on CI by [@​andrykonchin](https://togithub.com/andrykonchin) in [https://github.com/ruby/rake/pull/551](https://togithub.com/ruby/rake/pull/551) #### New Contributors - [@​zenspider](https://togithub.com/zenspider) made their first contribution in [https://github.com/ruby/rake/pull/525](https://togithub.com/ruby/rake/pull/525) - [@​gemmaro](https://togithub.com/gemmaro) made their first contribution in [https://github.com/ruby/rake/pull/530](https://togithub.com/ruby/rake/pull/530) - [@​janbiedermann](https://togithub.com/janbiedermann) made their first contribution in [https://github.com/ruby/rake/pull/451](https://togithub.com/ruby/rake/pull/451) - [@​andrykonchin](https://togithub.com/andrykonchin) made their first contribution in [https://github.com/ruby/rake/pull/551](https://togithub.com/ruby/rake/pull/551) **Full Changelog**: ruby/rake@v13.1.0...v13.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [x] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/powerhome/audiences). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Apr 11, 2024
zenspider
reviewed
May 5, 2024
| :nosearch, :rakelib, :show_all_tasks, :show_prereqs, | ||
| :show_task_pattern, :show_tasks, :silent, :suppress_backtrace_pattern, | ||
| :thread_pool_size, :trace, :trace_output, :trace_rules | ||
| ).new |
There was a problem hiding this comment.
It would be nicer if this was a named class:
NoMethodError: undefined method `verbose' for an instance of #<Class:0x00000001038112e0>
vs something like:
NoMethodError: undefined method `verbose' for an instance of #<Rake::Options:0x00000001038112e0>
janz93
added a commit
to lagardere-sports/ruby-client
that referenced
this pull request
Oct 10, 2024
Loading of "ostruct" depends on Rake, so we need to explicitly load it and resolve the dependency. Because Rake does not load "ostruct" since version 13.2.0. [ruby/rake#545](ruby/rake#545)
yahonda
added a commit
to yahonda/sprockets
that referenced
this pull request
Oct 22, 2024
](https://renovatebot.com){kind=link}
This commit bumps the required Rake version to suppress the following warnings: ```ruby $ ruby -v ruby 3.4.0dev (2024-10-21T16:48:53Z master 5131fb5dbe) +PRISM [x86_64-linux] $ bundle exec rake 2>&1 |grep -i ostruct ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add ostruct to your Gemfile or gemspec to silence this warning. /home/yahonda/.rbenv/versions/trunk/lib/ruby/gems/3.4.0+0/gems/rake-12.3.3/lib/rake/rake_test_loader.rb:2: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add ostruct to your Gemfile or gemspec to silence this warning. ./home/yahonda/src/github.com/rails/sprockets/lib/rake/sprocketstask.rb:2: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add ostruct to your Gemfile or gemspec to silence this warning. ``` - Rake v13.2.0 does not depend on OpenStruct https://github.com/ruby/rake/releases/tag/v13.2.0 ruby/rake#545 - Ruby 3.4.0dev emits OpenStruct warnings https://bugs.ruby-lang.org/issues/20309 ruby/ruby#10428
yahonda
added a commit
to yahonda/sprockets
that referenced
this pull request
Oct 22, 2024
This commit bumps the required Rake version to suppress the following warnings: ```ruby $ ruby -v ruby 3.4.0dev (2024-10-21T16:48:53Z master 5131fb5dbe) +PRISM [x86_64-linux] $ bundle exec rake 2>&1 |grep -i ostruct ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add ostruct to your Gemfile or gemspec to silence this warning. /home/yahonda/.rbenv/versions/trunk/lib/ruby/gems/3.4.0+0/gems/rake-12.3.3/lib/rake/rake_test_loader.rb:2: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add ostruct to your Gemfile or gemspec to silence this warning. ./home/yahonda/src/github.com/rails/sprockets/lib/rake/sprocketstask.rb:2: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add ostruct to your Gemfile or gemspec to silence this warning. ``` - Rake v13.2.0 does not depend on OpenStruct https://github.com/ruby/rake/releases/tag/v13.2.0 ruby/rake#545 - Ruby 3.4.0dev emits OpenStruct warnings https://bugs.ruby-lang.org/issues/20309 ruby/ruby#10428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will migrate
osturctas bundled gems at Ruby 3.5. We should remove its dependency from Rake.