refactor: move dependency requires to ruby_runner.rb
file
#609
+4
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three test cases that include the
RubyRunner
module:$ git grep -l 'include RubyRunner' test/test_rake_backtrace.rb test/test_rake_functional.rb test/test_rake_reduce_compat.rb $ _
... which previously required the indirect
open3
andfileutils
dependencies themselves, so this PR moves the requires toruby_runner.rb
where they belong.In addition, and in a separate commit to make reviewing easier, this PR also removes some superfluous
stringio
require statements in two other files that don't actually useStringIO
in any of their tests ... this was tested extensively by running each test in isolation (as opposed to "in bulk" usingrake test
) as follows:Thanks, @hsbt ! 🙏
PS - a nice side-effect of this refactor is that the
ruby_runner.rb
file is now "correct" Ruby code, which it currently - onmaster
- isn't: